Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove interface check at all #400

Merged
merged 1 commit into from
Sep 26, 2017
Merged

remove interface check at all #400

merged 1 commit into from
Sep 26, 2017

Conversation

ElectricMaxxx
Copy link
Member

and the next issue

@ElectricMaxxx ElectricMaxxx merged commit 3c6331f into master Sep 26, 2017
@ElectricMaxxx ElectricMaxxx deleted the fix_master branch September 26, 2017 21:30
@dbu
Copy link
Member

dbu commented Sep 27, 2017

so the templating service always is of the right interface if it exists, after all?

@ElectricMaxxx
Copy link
Member Author

Yes, as long as we do not composer require symfony/templating, which is kind of derpecated and configure it in framework configuration. the last is done on older apps, but not with the new component.

I really had trouble yesterday to get it working. as interface_exists() seems to require the interface and sends an warning.

you can now create a symfony skeleton app composer create-project "symfony/skeleton:^3.3", require cli (the comandline and cache calls won't work) composer req cli and call our reciepe then: SYMFONY_ENDPOINT=https://symfony.sh/r/github.com/symfony/recipes-contrib/91 composer remove symfony-cmf/routing-bundle and it should go green. In sandbox we have the former configuration with the old framework-bundle and that works fine too.

@dbu
Copy link
Member

dbu commented Sep 27, 2017

great job, thanks a lot max!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants